From 49465a32b646f060eee8201bafd0914972a0af41 Mon Sep 17 00:00:00 2001
From: Richard Petersen <richard.petersen@open-xchange.com>
Date: Mon, 9 May 2022 11:58:50 +0200
Subject: [PATCH] Fix: Redis is accessed to sync the version although disabled
---
src/create-queues.js | 8 +++++---
src/version.js | 8 ++++----
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/create-queues.js b/src/create-queues.js
index 6347c6b..db0df82 100644
--- a/src/create-queues.js
+++ b/src/create-queues.js
@@ -12,8 +12,10 @@ export default function createQueues () {
repeat: { every: Number(process.env.CACHE_TTL) },
removeOnComplete: true
})
- }
- // not a queue but though, used by redis
- registerLatestVersionListener(subClient)
+ // not a queue but though, used by redis
+ registerLatestVersionListener(subClient)
+ } else {
+ setInterval(updateVersionProcessor, Number(process.env.CACHE_TTL))
+ }
}
diff --git a/src/version.js b/src/version.js
index 4c82230..652877c 100644
--- a/src/version.js
+++ b/src/version.js
@@ -56,8 +56,6 @@ export function registerLatestVersionListener (client) {
client.on('message', (channel, message) => {
if (channel === key) latestVersion = message
})
- } else {
- setInterval(updateVersionProcessor, Number(process.env.CACHE_TTL))
}
}
@@ -67,7 +65,9 @@ export async function updateVersionProcessor () {
fetchLatestVersion()
])
if (storedVersion === fetchedVersion) return fetchedVersion
- redis.pubClient.publish(getRedisKey({ name: 'updateLatestVersion' }), fetchedVersion)
- await redis.client.set(getRedisKey({ name: 'latestVersion' }), fetchedVersion)
+ if (redis.isEnabled()) {
+ redis.pubClient.publish(getRedisKey({ name: 'updateLatestVersion' }), fetchedVersion)
+ await redis.client.set(getRedisKey({ name: 'latestVersion' }), fetchedVersion)
+ }
return fetchedVersion
}
--
GitLab