Skip to content
Snippets Groups Projects

Draft: Feature/vue

Open Draft: Feature/vue
feature/vue into main
2 unresolved threads
Open johann.jacobsohn requested to merge feature/vue into main
2 unresolved threads

Merge request reports

Merge request pipeline #1105591 failed

Stage: .pre
    Stage: test
      Stage: build
        Stage: deploy
          Stage: e2e
            Stage: publish

              Merge request pipeline failed for 5b6ea14b

              Approval is optional
              Merge blocked: 6 checks failed

              Merge details

              • The source branch is 177 commits behind the target branch.
              • 2 commits will be added to main.
              • Source branch will be deleted.

              Activity

              Filter activity
              • Approvals
              • Assignees & reviewers
              • Comments (from bots)
              • Comments (from users)
              • Commits & branches
              • Edits
              • Labels
              • Lock status
              • Mentions
              • Merge request status
              • Tracking
              src/com.example/my-first-start-wizard-page/manifest.json 0 → 100755
              1 [
              2 {
              3 "namespace": "first-start-wizard"
              4 },
              5 {
            • julian.baeume
              julian.baeume @julian.baeume started a thread on the diff
              • src/com.example/my-first-start-wizard-page/register.js 0 → 100755
              20
              21 import ext from '$/io.ox/core/extensions'
              22 import MyPage from './pages/my-page.vue'
              23
              24 // add a new page to the first start wizard
              25 ext.point('io.ox/first-start-widget').extend([
              26 {
              27 id: 'my-page',
              28 index: 150, // 100 is the title page, 200 is the first page, so 150 would position this page as the new first page
              29 component: MyPage
              30 },
              31 { // remove an existing page
              32 id: 'calendar-working-time',
              33 disabled: true
              34 },
              35 { // replace an existing page
              • julian.baeume
                julian.baeume @julian.baeume ·
                Owner

                Does this actually work? Reusing/overwriting an existing id is not supported and is highly dependent on timing. In debug mode we actually show warnings if this happens.

                If you actually want to replace something, don't call extend but replace on the extension point to indicate your actual intend.

              • Please register or sign in to reply
            • julian.baeume
              julian.baeume @julian.baeume ·
              Owner

              All in all, nice examples. I'd be happy to merge this as soon as we are sure this is the way we want to go :)

            • julian.baeume requested changes

              requested changes

              • Please register or sign in to reply