Skip to content
Snippets Groups Projects
Commit e785c241 authored by david.bauer's avatar david.bauer :fire:
Browse files

Change: Explicitly set content-type to utf-8 for javascript files

parent 63505fcb
No related branches found
No related tags found
No related merge requests found
...@@ -51,7 +51,7 @@ describe('With different app root', function () { ...@@ -51,7 +51,7 @@ describe('With different app root', function () {
it('serves files defined in manifest.json file', async function () { it('serves files defined in manifest.json file', async function () {
const response = await app.inject({ url: '/appsuite/example.js' }) const response = await app.inject({ url: '/appsuite/example.js' })
expect(response.statusCode).to.equal(200) expect(response.statusCode).to.equal(200)
expect(response.headers['content-type']).to.equal('application/javascript') expect(response.headers['content-type']).to.equal('application/javascript; charset=utf-8')
expect(response.body).to.equal('this is example') expect(response.body).to.equal('this is example')
const response2 = await app.inject({ url: '/appsuite/test.txt' }) const response2 = await app.inject({ url: '/appsuite/test.txt' })
......
...@@ -66,7 +66,7 @@ describe('File caching service', function () { ...@@ -66,7 +66,7 @@ describe('File caching service', function () {
it('serves files defined in manifest.json file', async function () { it('serves files defined in manifest.json file', async function () {
const response = await app.inject({ url: '/example.js' }) const response = await app.inject({ url: '/example.js' })
expect(response.statusCode).to.equal(200) expect(response.statusCode).to.equal(200)
expect(response.headers['content-type']).to.equal('application/javascript') expect(response.headers['content-type']).to.equal('application/javascript; charset=utf-8')
expect(response.body).to.equal('this is example') expect(response.body).to.equal('this is example')
// expect(response.headers['content-security-policy']).to.contain('sha256-NzZhMTE2Njc2YTgyNTZmZTdlZGVjZDU3YTNmYzRjNmM1OWZkMTI2NjRkYzZmMWM3YTkwMGU3ZTdhNDlhZmVlMwo=') // expect(response.headers['content-security-policy']).to.contain('sha256-NzZhMTE2Njc2YTgyNTZmZTdlZGVjZDU3YTNmYzRjNmM1OWZkMTI2NjRkYzZmMWM3YTkwMGU3ZTdhNDlhZmVlMwo=')
const response2 = await app.inject({ url: '/test.txt' }) const response2 = await app.inject({ url: '/test.txt' })
...@@ -113,7 +113,7 @@ describe('File caching service', function () { ...@@ -113,7 +113,7 @@ describe('File caching service', function () {
'http://ui-server': { 'http://ui-server': {
'/manifest.json': generateSimpleViteManifest({}), '/manifest.json': generateSimpleViteManifest({}),
'/example.js': spy = sandbox.spy(() => { '/example.js': spy = sandbox.spy(() => {
return new Response('this is example', { headers: { 'content-type': 'application/javascript' } }) return new Response('this is example', { headers: { 'content-type': 'application/javascript; charset=utf-8' } })
}) })
} }
}) })
...@@ -134,7 +134,7 @@ describe('File caching service', function () { ...@@ -134,7 +134,7 @@ describe('File caching service', function () {
'http://ui-server': { 'http://ui-server': {
'/manifest.json': generateSimpleViteManifest({}), '/manifest.json': generateSimpleViteManifest({}),
'/example.js': spy = sandbox.spy(() => { '/example.js': spy = sandbox.spy(() => {
return new Response('this is example', { headers: { 'content-type': 'application/javascript' } }) return new Response('this is example', { headers: { 'content-type': 'application/javascript; charset=utf-8' } })
}) })
} }
}) })
......
...@@ -38,7 +38,7 @@ export async function fetchFileWithHeadersFromBaseUrl ({ path, baseUrl, version ...@@ -38,7 +38,7 @@ export async function fetchFileWithHeadersFromBaseUrl ({ path, baseUrl, version
const result = { const result = {
body: Buffer.from(await response.arrayBuffer()), body: Buffer.from(await response.arrayBuffer()),
headers: { headers: {
'content-type': response.headers.get('content-type'), 'content-type': response.headers.get('content-type') === 'application/javascript' ? 'application/javascript; charset=utf-8' : response.headers.get('content-type'),
dependencies dependencies
} }
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment